Repository navigation
Update reserved_tags.json and the hed-tests submodule - #1503
Merged
Merged
Conversation
Copy reserved_tags.json unchanged from hed-specification (description now points to Appendix B.3) and move spec_tests/hed-tests to fe7eab6. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The hed-tests gitlink change is absent from the supplied diff and the local submodule is empty, so integration and fixture compatibility still require confirmation from initialized-submodule CI.
No open issues 🎉
What changed in this PR
Refreshes upstream HED specification metadata and test fixtures. The reviewed JSON change updates documentation without changing validation behavior.
Changes:
- Replaces the description's earlier-schema explanation with a reference to Appendix B.3.
- Leaves structured validation rules and version fields unchanged.
- The PR description also records a
hed-testssubmodule update tofe7eab6; that change was not included in the supplied diff.
| File | Description |
|---|---|
hed/validator/data/reserved_tags.json |
Updates descriptive metadata to reference Appendix B.3 for earlier-schema differences. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy reserved_tags.json unchanged from hed-specification (description now points to Appendix B.3) and move spec_tests/hed-tests to fe7eab6.